Repository navigation
fabtests/common: check the connect result in ft_init_fabric_cm() - #13196
Merged
Merged
Conversation
ft_init_fabric_cm() ignored the return value of ft_client_connect() /
ft_server_connect() before checking fi->caps for the
FT_OPT_NO_PRE_POSTED_RX case. If connection setup failed before fi was
allocated (e.g. fi_getinfo() returning -FI_ENODATA because the provider
does not support FI_EP_MSG), the test dereferenced a NULL fi and
crashed with SIGSEGV instead of returning the error.
runfabtests.sh reports a test as "Notrun" only if both sides exit with
FI_ENODATA, so the crash turned an unsupported configuration into a
failure:
fi_flood -e msg -v -T 1 -p "ofi_rxm;tcp"
server: fi_getinfo(): ret=-61 (No data available), exit 61
client: fi_getinfo(): ret=-61, then Segmentation fault, exit 139
-> result: Fail
Return the error as soon as connecting fails. The client now exits
with 61 and the test is reported as Notrun.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
j-xiong
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ft_init_fabric_cm() ignored the return value of ft_client_connect() / ft_server_connect() before checking fi->caps for the FT_OPT_NO_PRE_POSTED_RX case. If connection setup failed before fi was allocated (e.g. fi_getinfo() returning -FI_ENODATA because the provider does not support FI_EP_MSG), the test dereferenced a NULL fi and crashed with SIGSEGV instead of returning the error.
runfabtests.sh reports a test as "Notrun" only if both sides exit with FI_ENODATA, so the crash turned an unsupported configuration into a failure:
fi_flood -e msg -v -T 1 -p "ofi_rxm;tcp"
server: fi_getinfo(): ret=-61 (No data available), exit 61
client: fi_getinfo(): ret=-61, then Segmentation fault, exit 139
-> result: Fail
Return the error as soon as connecting fails. The client now exits with 61 and the test is reported as Notrun.